Skip to content

Fixed 39 : urls to get informations about watching #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 30, 2014

Conversation

Nek-
Copy link
Contributor

@Nek- Nek- commented Dec 31, 2013

No description provided.

@cursedcoder
Copy link
Contributor

Please fix tests :)

@@ -367,7 +367,7 @@ public function teams($username, $repository)
*/
public function watchers($username, $repository, $page = 1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be good to add subscribers method and fill this as @deprecated, same for other methods

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And throw an exception ? Because there is no need to keep a method not working, isn't it ?

cursedcoder added a commit that referenced this pull request Jan 30, 2014
Fixed 39 : urls to get informations about watching
@cursedcoder cursedcoder merged commit d51c9fe into KnpLabs:master Jan 30, 2014
@Nek- Nek- deleted the follow-github-watch-api branch January 30, 2014 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants